Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/scan fingerprints #36

Merged
merged 13 commits into from
Jan 30, 2024
Merged

Feature/scan fingerprints #36

merged 13 commits into from
Jan 30, 2024

Conversation

oussamaessaji
Copy link
Member

No description provided.

mohsinenar
mohsinenar previously requested changes Jan 26, 2024
View reviewed changes
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
rabsondev
rabsondev previously requested changes Jan 26, 2024
View reviewed changes
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
benyissa
benyissa reviewed Jan 26, 2024
View reviewed changes
tests/osv_agent_test.py Outdated Show resolved Hide resolved
benyissa
benyissa reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@benyissa benyissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why to have api_mnanager as folder instead of module in same level, apis.py that have this logic

deadly-panda
deadly-panda previously requested changes Jan 26, 2024
View reviewed changes
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/osv_agent.py Outdated Show resolved Hide resolved
agent/osv_agent.py Outdated Show resolved Hide resolved
agent/osv_output_handler.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
ErebusZ
ErebusZ reviewed Jan 26, 2024
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
agent/osv_agent.py Outdated Show resolved Hide resolved
3asm
3asm requested changes Jan 29, 2024
View reviewed changes
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Outdated Show resolved Hide resolved
agent/api_manager/osv_service_api.py Show resolved Hide resolved
agent/api_manager/osv_service_api.py Show resolved Hide resolved
agent/osv_agent.py Outdated Show resolved Hide resolved
agent/osv_agent.py Outdated Show resolved Hide resolved
agent/osv_agent.py Outdated Show resolved Hide resolved
agent/osv_agent.py Outdated Show resolved Hide resolved
ostorlab.yaml Outdated Show resolved Hide resolved
3asm
3asm approved these changes Jan 29, 2024
View reviewed changes
ostorlab.yaml Outdated Show resolved Hide resolved
@3asm 3asm dismissed stale reviews from deadly-panda, rabsondev, and mohsinenar January 30, 2024 04:14

Issues fixed.

@3asm 3asm merged commit 0b0e930 into main Jan 30, 2024
3 checks passed
@3asm 3asm deleted the Feature/Scan_fingerprints branch January 30, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benyissa benyissa benyissa left review comments

@BlueSquare1 BlueSquare1 BlueSquare1 left review comments

@3asm 3asm 3asm approved these changes

@amine3 amine3 amine3 approved these changes

@rabsondev rabsondev Awaiting requested review from rabsondev

@ErebusZ ErebusZ Awaiting requested review from ErebusZ

@elyousfi5 elyousfi5 Awaiting requested review from elyousfi5

@deadly-panda deadly-panda Awaiting requested review from deadly-panda

@mohsinenar mohsinenar Awaiting requested review from mohsinenar

@PiranhaSa PiranhaSa Awaiting requested review from PiranhaSa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@oussamaessaji @3asm @amine3 @deadly-panda @mohsinenar @rabsondev @ErebusZ @BlueSquare1 @elyousfi5 @benyissa