Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match DNA generation with vulnz_matcher #65

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Zakaria-Latif
Copy link
Member

@Zakaria-Latif Zakaria-Latif commented Oct 16, 2024

The DNA of the vulnerabilities reported by OSV does not contain paths like those in the vulnz_matcher.
Also the CVEs in the two findings are not identical some are common, while others are unique to each finding.
Scan: https://report.ostorlab.co/scan/125255/
Vuln 1: https://report.ostorlab.co/scan/125255/vuln/25060/risk/critical
Vuln 2: https://report.ostorlab.co/scan/125255/vuln/29640/risk/info

⚠️ So this fix will guarantee the same method of DNA generation, but not the same DNA if the CVEs are different.

@Zakaria-Latif Zakaria-Latif self-assigned this Oct 16, 2024
@Zakaria-Latif Zakaria-Latif changed the title Match dna generation with vulnz_matcher Match DNA generation with vulnz_matcher Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (6aa16c4) to head (8d6fc60).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files          13       13           
  Lines         850      850           
=======================================
  Hits          808      808           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3asm 3asm merged commit a13403a into main Oct 16, 2024
5 checks passed
@3asm 3asm deleted the bugfix/bugfix/match-dna-generation-with-vulnz-matcher branch October 16, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants