Fix/solar zenith time cast #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cast() function in the cosine_of_solar_zenith_angle function had incorrect argument order, placing the np.ndarray type before the value to cast. This fixes the order to cast(time.values, np.ndarray) to correctly type-cast the CFTime values before converting to seconds.
Add name to AUTHORS.rst as per contribution guidelines.
|
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨ |
aulemahal
approved these changes
Mar 5, 2025
|
@jack-ktw I allowed myself to add a test that would have detected the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
2097) and pull request (:pull:2098) has been addedWhat kind of change does this PR introduce?
Bug fix: Correct parameter order in typing.cast() causing intermittent errors in solar_zenith_angle calculation
Does this PR introduce a breaking change?
No
Other information:
his fix corrects a parameter ordering issue in the typing.cast() function call which was causing intermittent errors when processing multiple climate datasets in parallel. The fix is minimal and simply swaps the parameters to match the correct typing.cast(type, value) signature.