Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable py310 and add support policy #2100

Merged
merged 7 commits into from
Mar 7, 2025
Merged

Reenable py310 and add support policy #2100

merged 7 commits into from
Mar 7, 2025

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Mar 7, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Re-enables support for Python3.10.
  • Adds a support policy page to the documentation explaining our reasoning behind dropping/supporting new versions.

Does this PR introduce a breaking change?

No, in fact it reverts a breaking change.

Other information:

Internal discussions among the development team had us wondering if we were maybe too quick to drop Python3.10. It's possible that we will drop it once xarray terminates support (perhaps by summer, 2025).

The support policy could be adapted to multiple projects. Might be a good idea for posterity.

@Zeitsperre Zeitsperre added standards / conventions Suggestions on ways forward information For development/intsructional purposes dependencies Pull requests that update a dependency file labels Mar 7, 2025
@Zeitsperre Zeitsperre requested a review from a team March 7, 2025 19:49
@Zeitsperre Zeitsperre self-assigned this Mar 7, 2025
@github-actions github-actions bot added CI Automation and Contiunous Integration docs Improvements to documenation labels Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2025.1.8).

No further action is required.

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but I would promise even less support for non-spec0 python versions.

@github-actions github-actions bot added the approved Approved for additional tests label Mar 7, 2025
@Zeitsperre Zeitsperre merged commit 5fb64a4 into main Mar 7, 2025
24 checks passed
@Zeitsperre Zeitsperre deleted the reenable-py310 branch March 7, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration dependencies Pull requests that update a dependency file docs Improvements to documenation information For development/intsructional purposes standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants