Skip to content

Commit

Permalink
ROU-11327: Fix tooltip issue with Grouped Columns and increment versi…
Browse files Browse the repository at this point in the history
…on (#437)

* Fix tooltip issue with Grouped Columns and increment version

* Update ToolTip.ts

* Update ToolTip.ts

* Update ToolTip.ts
  • Loading branch information
gnbm authored Oct 31, 2024
1 parent 05f5d00 commit 5fc3a5d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
2 changes: 1 addition & 1 deletion gulp/DefaultSpecs.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const constants = {

// Store the default project specifications
const specs = {
version: '2.17.0',
version: '2.18.0',
name: 'OutSystems DataGrid',
description: '',
url: 'Website:\n • ' + constants.websiteUrl,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "outsystems-datagrid",
"version": "2.17.0",
"version": "2.18.0",
"description": "OutSystems Data Grid for Reactive Web",
"author": "UI Components Team",
"license": "BSD-3-Clause",
Expand Down
2 changes: 1 addition & 1 deletion src/OSFramework/DataGrid/Constants.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
namespace OSFramework.DataGrid.Constants {
/* OutSystems Data Grid Version */
export const OSDataGridVersion = '2.17.0';
export const OSDataGridVersion = '2.18.0';
/* OutSystems null values */
export const OSNullDate = '1900-01-01';
export const OSNullDateTime = '1900-01-01T00:00:00';
Expand Down
10 changes: 8 additions & 2 deletions src/Providers/DataGrid/Wijmo/Features/ToolTip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,14 @@ namespace Providers.DataGrid.Wijmo.Feature {
this._setCellTooltip(_currTarget, ht.getColumn().binding, ht.row);
}
} else if (cellType === wijmo.grid.CellType.ColumnHeader) {
// If the Column Header is from a Group Column, we need to use a different approach that the regular header
if (_currTarget.classList.contains(Helper.Constants.CssClasses.ColumnGroup)) {
const col = ht.getColumn(true) as wijmo.grid.ColumnGroup;
// If the Column Header is from a Group Column, we need to use a different approach than the regular header
// We can check if the current target is a ColumnGroup by checking its class and if it has columns or columnGroups
if (
_currTarget.classList.contains(Helper.Constants.CssClasses.ColumnGroup) &&
((col._binding === undefined && col.columns !== undefined && col.columns.length > 0) ||
(col.columnGroups !== undefined && col.columnGroups.length > 0))
) {
this._setColumnGroupHeaderTooltip(_currTarget);
} else {
this._setHeaderTooltip(_currTarget, ht);
Expand Down

0 comments on commit 5fc3a5d

Please sign in to comment.