Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11162: Fix alignment issue in filters when used on a popup #433

Closed
wants to merge 5 commits into from

Conversation

gnbm
Copy link
Collaborator

@gnbm gnbm commented Sep 10, 2024

What was happening

  • When used inside a popup, the filter's dropdown values got misaligned, changing to a centered alignment and the Grid content and pagination got bold.

What was done

  • Added the default CSS properties to cover these use cases and apply them to RTL as well.

Test Steps

  • Test Case 1:

    • Go to the test page
    • Check the Grid styles are correct as well as the pagination and the filters (by condition / by value)
    • Click on “Open Grid in Popup“
    • Check the Grid styles are correct as well as the pagination and the filters (by condition / by value)
  • Test Case 2 - RTL:

    • Go to the test page
    • Select ar-AE locale to enable RTL
    • Check the Grid styles are correct as well as the pagination and the filters (by condition / by value)
    • Click on “Open Grid in Popup“
    • Check the Grid styles are correct as well as the pagination and the filters (by condition / by value)

Screenshots

image

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems
  • requires new sample page in OutSystems (if so, provide a module with changes)

@gnbm gnbm added the bug Something isn't working label Sep 10, 2024
@gnbm gnbm requested a review from a team as a code owner September 10, 2024 22:52
BenOsodrac
BenOsodrac previously approved these changes Sep 11, 2024
@gnbm gnbm dismissed stale reviews from OS-giulianasilva and BenOsodrac via bc4bfdc September 11, 2024 12:46
Copy link

@gnbm gnbm closed this Sep 11, 2024
@gnbm gnbm deleted the ROU-11162 branch September 11, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants