Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4709: Change markerclusterer library + adding new API #156

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Conversation

rugoncalves
Copy link
Contributor

This PR is for changing the library for creating the marker clusters, consequently adding changing the way the clusters are are created. This is causes a breaking change in case the application is setting the marker clusters to true, and changing the UI of the clusters via CSS.

What was happening

  • OutSystems Maps was using a deprecated and no longer supported library
  • The library was using deprecated APIs and throwing warnings in the console

What was done

  • Changed the library to use the official and supported library
  • Changed the code to respond appropriate to input parameters and changes in blocks
  • Added new API to enable changing the Markers Cluster icon. Sample on how to do it here

Screenshots

Gif with cluster behavior

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@rugoncalves rugoncalves requested a review from a team as a code owner February 2, 2024 14:57
@outsystemsbot outsystemsbot bot added the cla:yes label Feb 2, 2024
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gnbm gnbm merged commit 5f368b8 into dev Feb 5, 2024
11 checks passed
@gnbm gnbm deleted the ROU-4709 branch February 5, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants