oopsy: add new helpers for missed/multiple events

[wexxlee]

This PR adds some new helpers to oopsy, specifically:

• missedWarn/missedFail: Generate a mistake for players who did not get hit by a particular action. The most obvious glaring need for this is missing a party/light-party stack.
• multipleWarn/multipleFail: Generate a mistake for players who got hit multiple times by the same action. Common uses would be getting hit by two role cleaves or more than X hits of a persistent ground effect, etc.

(These helpers are all on the current oopsy to-do list).

To implement these helpers, this PR also extends the current MistakeMap type in oopsy to now accept params instead of just an action/effect id -- among other things, to make it possible to limit mistakes to particular roles, control the amount of time a missed/multiple mistake will collect for, override the default mistake text, etc.

Marking this as a draft for now because it still needs more in-game testing and some docs updates. Would greatly appreciate any early feedback though.

[JLGarber]

Thanks for putting all that together. I think that's a reasonable direction for us to take this. I don't have a ton to say about it right now since I haven't touched the Oopsy internals for a while, but definitely continue with it this way and let's see where it lands.

[JLGarber]

This definition should probably go before the comment for slightly easier readability.

[JLGarber]

I don't feel particularly strongly about this, but do we maybe want to break the evaluation and assignment into multiple lines, just to make it slightly more readable at the expense of vertical height?

It's maybe a little unfortunate that the map structures don't really allow us to group the warning and fail maps to loop through those groups instead. I can't think of a better way to structure this right now, but I wonder whether there's something we could do to reduce the Giant Loop Tower somehow, since otherwise it will only grow if we add anything new.

[valarnin]

Something like this?

// @TODO: Add to this type guard to cover the MistakeDetails class too.
const isMistakeMap = (v: unknown): v is MistakeMap => {
  if (typeof v !== 'object' || v === null)
    return false;

  if (!Object.keys(v).every((k) => typeof k === 'string')) {
    return false;
  }

  if (!Object.values(v).every((v) => typeof v === 'string')) {
    return false;
  }

  return true;
};

const extractMistakeMaps = (set: ProcessedOopsyTriggerSet): { [key: string]: MistakeMap } => {
  const ret: { [key: string]: MistakeMap } = {};
  for (const entry of Object.entries(set)) {
    const key = entry[0];
    if (typeof key !== 'string')
      continue;
    const value = entry[1];
    if (isMistakeMap(value)) {
      ret[key] = value;
    }
  }
  return ret;
};

// ...
  PushTriggerSet(set: ProcessedOopsyTriggerSet): void {
    this.triggerSets.push(set);
    for (const set of this.triggerSets) {
      for (const mapEntry of Object.entries(extractMistakeMaps(set))) {
        const warnFail = mapEntry[0].endsWith('Warn') ? 'warn' : 'fail';
        const map = mapEntry[1];
        for (const value of Object.values(map)) {
          const key = typeof value === 'object' ? value.id : value;
          this.mistakeDamageMap[key] = warnFail;
        }
      }
    }
  }

[JLGarber]

Yeah, that seems reasonable. It's maybe a little bit more to read and absorb, but should require less overall maintenance in future, I think

[wexxlee]

Thanks for the feedback! And yeah, @valarnin 's suggestion looks good to me too. I'll probably wait to pick this back up until after we get thru 7.11 updates next week, but I think this is fairly close, just needs a little more in-game testing.