util: Coverage Report additions #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
config
|
Would "Release Version" a better name instead of Status? |
|
Renamed column, added colors, added PR info for open PRs. Maybe it makes more sense to list the open PRs first and the date second? From an information standpoint I don't think there's any more I can do here. Linking to a give PR/release/etc doesn't really work very well with the current table's structure, I think we'd need to rewrite the entire presentation layer to have that make sense. (css grid is making this frustrating to deal with)
|
JLGarber
approved these changes
Jan 12, 2025
|
Probably worth reversing open PRs and the date, yes, but not a big deal either way. I think making it clear what is and isn't released yet is the big win here. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2025
- Add "other" content to coverage report - Add spacer row between expansions/other triggers - Have coverage report use zone label where appropriate - Clean up duplicate `kPrefixToCategory` - Add `Comments` column and associated field to `TriggerSet` - Add `Status` column - Add colors - Add PRs a1008d5
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Jan 13, 2025
- Add "other" content to coverage report - Add spacer row between expansions/other triggers - Have coverage report use zone label where appropriate - Clean up duplicate `kPrefixToCategory` - Add `Comments` column and associated field to `TriggerSet` - Add `Status` column - Add colors - Add PRs a1008d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kPrefixToCategoryCommentscolumn and associated field toTriggerSetStatuscolumnStatusisn't really a good name for the column but it's 4:30am and I'm out of brainpower to think about things like names.Hovering over the
Statuscolumn's values will show the date/time of the commit (for unreleased) or tag (for released).Example comment in screenshot was not actually committed.