Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-instance configs (#165) #177

Merged

Conversation

mykhailodanilenko
Copy link
Contributor

🚀 Description

This PR changes the featured instances file from .json to .json5; adds customizations to instance info in the file, allowing for greater control over featured instance display; adds a unit test that validates the file to conform to the specified schema to prevent breaking changes to the config. Available at https://mykhailodanilenko.github.io/web-client/. Also, moved the Swebbtv instance higher on the list.

📄 Motivation and Context

#165

🧪 How Has This Been Tested?

Web and mobile

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist (copied from README)

  • Squash your changes into a single clear and thoroughly descriptive commit, split changes into multiple commits only when it contributes to readability
  • Reference the GitHub issue that you are contributing on in your commit title or body
  • Sign your commits, as this is required by the automated GitHub PR checks
  • Ensure that the changes adhere to the project code style and formatting rules by running npx eslint . and npx prettier --check ../ from the ./OwnTube.tv/ directory (without errors/warnings)
  • Include links and illustrations in your pull request to make it easy to review
  • Request a review by @mykhailodanilenko, @ar9708 and @mblomdahl

@mykhailodanilenko mykhailodanilenko added enhancement New feature or request 2nd review queue Scheduled for "2nd opinion" review labels Sep 26, 2024
@mykhailodanilenko mykhailodanilenko self-assigned this Sep 26, 2024
Copy link
Contributor

@mblomdahl mblomdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the concerns I had with async loading to the backlog as #179 after another round of trying all the strategies in JSON5 documentation, so let's revisit this "later". 🙃

OwnTube.tv/public/featured-instances.json5 Outdated Show resolved Hide resolved
@mykhailodanilenko mykhailodanilenko merged commit 6cfc1d1 into OwnTube-tv:main Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2nd review queue Scheduled for "2nd opinion" review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants