Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent type size_t for node_count() in C++ bindings #9

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Apr 15, 2024

While trying to compile the C++ bindings, I had some compilation errors because node_count() different types.

This PR consistently uses uint64_t as default for node_count() because it seemed more widely used. One could of course also use size_t instead.

@nhusung nhusung changed the title Use consistent type uint64_t for node_count() in C++ bindings Use consistent type size_t for node_count() in C++ bindings Apr 20, 2024
@nhusung
Copy link
Member

nhusung commented Apr 20, 2024

Thank you! I’d rather opt for size_t everywhere. Somehow, clang++ and g++ did never complain about the type mismatches. Which compiler / OS did you use?

@nhusung nhusung merged commit 82e4531 into OxiDD:main Apr 20, 2024
4 checks passed
@volkm
Copy link
Contributor Author

volkm commented Apr 20, 2024

Thanks for integrating it.

BTW I used Clang 16.0.6 on the Apple M3 chip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants