all: random cleanup

OxygenCobalt · Oct 17, 2023 · 48b0b11 · 48b0b11
1 parent f4518eb
commit 48b0b11
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,10 @@ aspect ratio setting
 #### What's Fixed
 - Playlist detail view now respects playback settings
 
+
+#### Dev/Meta
+- Revamped navigation backend
+
 ## 3.1.4
 
 #### What's Fixed

diff --git a/app/src/main/java/org/oxycblt/auxio/MainFragment.kt b/app/src/main/java/org/oxycblt/auxio/MainFragment.kt
@@ -204,6 +204,10 @@ class MainFragment :
     }
 
     override fun onPreDraw(): Boolean {
+        // TODO: Due to draw caching even *this* isn't effective enough to avoid the bottom
+        //  sheets continually getting stuck. I need something with even more frequent updates,
+        //  or otherwise bottom sheets get stuck.
+
         // We overload CoordinatorLayout far too much to rely on any of it's typical
         // listener functionality. Just update all transitions before every draw. Should
         // probably be cheap enough.

diff --git a/app/src/main/java/org/oxycblt/auxio/music/MusicRepository.kt b/app/src/main/java/org/oxycblt/auxio/music/MusicRepository.kt
@@ -223,8 +223,7 @@ constructor(
     private val mediaStoreExtractor: MediaStoreExtractor,
     private val tagExtractor: TagExtractor,
     private val deviceLibraryFactory: DeviceLibrary.Factory,
-    private val userLibraryFactory: UserLibrary.Factory,
-    private val musicSettings: MusicSettings
+    private val userLibraryFactory: UserLibrary.Factory
 ) : MusicRepository {
     private val updateListeners = mutableListOf<MusicRepository.UpdateListener>()
     private val indexingListeners = mutableListOf<MusicRepository.IndexingListener>()

diff --git a/app/src/main/java/org/oxycblt/auxio/music/metadata/TextTags.kt b/app/src/main/java/org/oxycblt/auxio/music/metadata/TextTags.kt
@@ -22,7 +22,6 @@ import androidx.media3.common.Metadata
 import androidx.media3.extractor.metadata.id3.InternalFrame
 import androidx.media3.extractor.metadata.id3.TextInformationFrame
 import androidx.media3.extractor.metadata.vorbis.VorbisComment
-import org.oxycblt.auxio.util.logD
 
 /**
  * Processing wrapper for [Metadata] that allows organized access to text-based audio tags.