playback: fix crash when song cannot be restored

The index is -1, which is not a valid position to seek through normally. In this case we should just ignore it.
OxygenCobalt · Jan 22, 2024 · b53a96f · b53a96f
1 parent 588b6e9
commit b53a96f
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackStateManager.kt b/app/src/main/java/org/oxycblt/auxio/playback/state/PlaybackStateManager.kt
@@ -774,18 +774,21 @@ class PlaybackStateManagerImpl @Inject constructor() : PlaybackStateManager {
                         index
                     })
 
-        val oldStateMirror = stateMirror
-
-        if (oldStateMirror.rawQueue != rawQueue) {
-            logD("Queue changed, must reload player")
-            stateHolder?.applySavedState(parent, rawQueue, StateAck.NewPlayback)
-            stateHolder?.playing(false)
-        }
+        if (index > -1) {
+            // Valid state where something needs to be played, direct the stateholder to apply
+            // this new state.
+            val oldStateMirror = stateMirror
+            if (oldStateMirror.rawQueue != rawQueue) {
+                logD("Queue changed, must reload player")
+                stateHolder?.applySavedState(parent, rawQueue, StateAck.NewPlayback)
+                stateHolder?.playing(false)
+            }
 
-        if (oldStateMirror.progression.calculateElapsedPositionMs() != savedState.positionMs) {
-            logD("Seeking to saved position ${savedState.positionMs}ms")
-            stateHolder?.seekTo(savedState.positionMs)
-            stateHolder?.playing(false)
+            if (oldStateMirror.progression.calculateElapsedPositionMs() != savedState.positionMs) {
+                logD("Seeking to saved position ${savedState.positionMs}ms")
+                stateHolder?.seekTo(savedState.positionMs)
+                stateHolder?.playing(false)
+            }
         }
 
         isInitialized = true