Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish PCP Client SDK #10

Merged
merged 27 commits into from
Sep 6, 2024
Merged

Finish PCP Client SDK #10

merged 27 commits into from
Sep 6, 2024

Conversation

Brudus
Copy link
Collaborator

@Brudus Brudus commented Sep 1, 2024 •
edited
Loading

This will add

  • the missing tests (coverage >85%)
  • the missing documentation (inline + README)
  • contribution guidelines
  • an example HTML for the creditcard tokenizer.

@Brudus
ADD inline code documentation
3f5d5fc
@Brudus
ADD possible tests for FingerprintTokenizer
30436e0
@Brudus
FIX linting issues
6e2702d
@Brudus
CHANGE increase waiting time for test expectation
c307eab
@Brudus
ADD more tests for FingerprintTokenizer
6d0c021
@Brudus
FIX linting issues
15fc9f6
@Brudus
REFACTOR move test code into setup and teardown to avoid code duplica…
749de60 
…tion
@Brudus
FIX linting issues
ae9ff20
@Brudus
REMOVE broken test on CI
c206892
@Brudus
ADD tests for PCPEnvironment
23bb1bb
@Brudus
ADD pre-commit config
58fff3f
@Brudus
ADD tests for ApplePayHandler
2c9a882
@Brudus
CHORE update excluded files from coverage
50aeb4c
@Brudus
CHORE update coverage exclusions again
477162f
@Brudus
CHANGE update test to check correct case
28cc265
@Brudus
ADD tests for CCScriptMessageType
61b87a4
@Brudus
ADD tests for PayoneLanguage type
0d6018f
@Brudus
ADD test for SupportedCardType logic
d036b97
@Brudus
ADD first tests for CreditcardTokenizerViewController
f1f3d27
@Brudus
ADD tests to assure initial logic script is correctly injected and li…
47d81fb 
…steners are set up
@Brudus
ADD remaining tests for CreditcardTokenizerViewController
1c4bb4e
@Brudus
CHORE remove CreditcardTokenizerView from coverage
9126fcf
@Brudus
REMOVE unused code
f0785fc
@Brudus
ADD inline code documentation
5cf5931
@Brudus
DOCS add proper README
28fdf0b
@Brudus
ADD CONTRIBUTING.md
00f88df
@Brudus Brudus changed the title Feature/finish fingerprint tokenizer Finish PCP Client SDK Sep 6, 2024
@Brudus Brudus marked this pull request as ready for review September 6, 2024 20:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Brudus Brudus merged commit 297f587 into main Sep 6, 2024
3 checks passed
@Brudus Brudus deleted the feature/finish-fingerprint-tokenizer branch September 6, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Brudus