Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some real EBCDIC testing #656

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

NWilson
Copy link
Member

@NWilson NWilson commented Jan 7, 2025

Part of #655

We currently don't have any testing in CI whatsoever for the EBCDIC code. I know it's obscure, but I feel it ought be tested at least a little before we put out a release.

I'm making it so that you can now compile a version of the PCRE2 libraries which fully-support EBCDIC, on any platform, with any compiler.

This lets us now write some proper EBCDIC tests and run them in CI.

@NWilson NWilson force-pushed the user/niwilson/ebcdic-test branch 2 times, most recently from fb1c448 to 4b9f908 Compare January 7, 2025 17:29
@NWilson
Copy link
Member Author

NWilson commented Jan 13, 2025

I've been undecided about what's the best test suite to run on the EBCDIC build.

Here's my decision: I want to run the full test suite (1 to 27), but obviously there will be some failures. I'll introduce a new "#ifndef EBCDIC" directive in the test input/output files, to mask out the specific tests that fail in EBCDIC mode. These will be ones of the form does [\x10-\x60] match 'A' and similar things.

I basically don't want to add a new "testoutputN-EBC" for every testoutput file (too verbose when writing tests). Nor do I want to just skip all the existing tests. Nor can we somehow maintain a list of "expected failures" under EBCDIC.

I'll also rename the existing "testinputEBC" to "testinput28" and just make it conditional the EBCDIC build, in the same way that lots of existing tests are conditional on build properties.

@zherczeg
Copy link
Collaborator

Is it possible to really test EBCDIC on ASCII? I hope this will not make our life difficult.

@NWilson
Copy link
Member Author

NWilson commented Jan 13, 2025

Yes, it's totally possible. It's in the PR currently, I just haven't updated the RunTest script to get all the tests passing.

It's also necessary to test the EBCDIC code - I just don't feel comfortable shipping lines of code that we haven't compiled or tested.

@NWilson NWilson force-pushed the user/niwilson/ebcdic-test branch 2 times, most recently from 06219fc to fdeb41f Compare January 13, 2025 22:13
@NWilson NWilson force-pushed the user/niwilson/ebcdic-test branch from f9ca812 to aea53cd Compare January 16, 2025 12:37
@NWilson NWilson force-pushed the user/niwilson/ebcdic-test branch from 71351f4 to ec9fdc8 Compare January 16, 2025 17:27
@NWilson NWilson force-pushed the user/niwilson/ebcdic-test branch from 2bc730f to 8613839 Compare January 17, 2025 16:19
@NWilson NWilson force-pushed the user/niwilson/ebcdic-test branch from b1d55a2 to 775385d Compare January 17, 2025 16:45
@NWilson NWilson marked this pull request as ready for review January 17, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants