-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some real EBCDIC testing #656
base: master
Are you sure you want to change the base?
Conversation
fb1c448
to
4b9f908
Compare
I've been undecided about what's the best test suite to run on the EBCDIC build. Here's my decision: I want to run the full test suite (1 to 27), but obviously there will be some failures. I'll introduce a new "#ifndef EBCDIC" directive in the test input/output files, to mask out the specific tests that fail in EBCDIC mode. These will be ones of the form I basically don't want to add a new "testoutputN-EBC" for every testoutput file (too verbose when writing tests). Nor do I want to just skip all the existing tests. Nor can we somehow maintain a list of "expected failures" under EBCDIC. I'll also rename the existing "testinputEBC" to "testinput28" and just make it conditional the EBCDIC build, in the same way that lots of existing tests are conditional on build properties. |
Is it possible to really test EBCDIC on ASCII? I hope this will not make our life difficult. |
Yes, it's totally possible. It's in the PR currently, I just haven't updated the RunTest script to get all the tests passing. It's also necessary to test the EBCDIC code - I just don't feel comfortable shipping lines of code that we haven't compiled or tested. |
06219fc
to
fdeb41f
Compare
f9ca812
to
aea53cd
Compare
71351f4
to
ec9fdc8
Compare
2bc730f
to
8613839
Compare
b1d55a2
to
775385d
Compare
Part of #655
We currently don't have any testing in CI whatsoever for the EBCDIC code. I know it's obscure, but I feel it ought be tested at least a little before we put out a release.
I'm making it so that you can now compile a version of the PCRE2 libraries which fully-support EBCDIC, on any platform, with any compiler.
This lets us now write some proper EBCDIC tests and run them in CI.