Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionScopeValidation): use action scope in class #1303

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

TTtie
Copy link
Contributor

@TTtie TTtie commented Feb 29, 2024

Corrects cases when specifying an invalid action scope results in incorrect errors of "Wrong action scope, got SCOPE but expected SCOPE" where the expected scope is the scope from the action definition. This PR corrects the oversight and uses the scope from the class instead.

Corrects cases when specifying an invalid action scope results in incorrect errors of "Wrong action scope, got SCOPE but expected SCOPE" where the expected scope is the scope from the action definition. This commit corrects the oversight and uses the scope from the class instead.

Signed-off-by: TTtie <[email protected]>
@TTtie TTtie requested a review from Electroid as a code owner February 29, 2024 01:11
Pablete1234
Pablete1234 previously approved these changes Feb 29, 2024
Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probs be better to just rename the local variable to something else so it doesn't shadow the field, but this is fine too

@Pablete1234 Pablete1234 added bug Something isn't working ready PR is ready to merge labels Feb 29, 2024
@Electroid Electroid merged commit 2708649 into PGMDev:dev Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

3 participants