Add disguise check and fix nicked user bug #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: applenick <[email protected]>
Pablete1234
approved these changes
Aug 2, 2024
Pablete1234
pushed a commit
that referenced
this pull request
Nov 30, 2024
Signed-off-by: applenick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new method to the
Integrationclass that determines if a player is disguised (either vanished or nicked). Additionally, it addresses a minor bug where nicked users were not correctly hidden from the multiplayer server list ping.I reviewed all instances where
Integration#isVanishedis used, and only the one fixed below needed to be changed. If you think there are other places where this check should be applied, please let me know 👍 Otherwise, this should be ready to go.