Fix tab entries dirty set leaking views, players & worlds #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Herrera <[email protected]>
Signed-off-by: Pablo Herrera <[email protected]>
cswhite2000
approved these changes
Aug 17, 2024
Pablete1234
added a commit
that referenced
this pull request
Nov 30, 2024
Signed-off-by: Pablo Herrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tab entries have a dirtyset/cleanset that holds all views that need/don't need updating. Tab views get dynamically added/removed to those sets when the entry starts/stops being used, but on cleanup when a player leaves, the entries aren't removed.
That causes the following chain to stay in memory:
TabEntry.dirtySet -> TabView.viewer -> bukkit Player -> nms player -> nms world -> chunks etc