Fix balance message being used for priority kick #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Herrera <[email protected]>
Pablete1234
force-pushed
the
fix-join-kick-msg
branch
from
ad70720 to
4e80b34
Compare
cswhite2000
approved these changes
Nov 24, 2024
Pablete1234
added a commit
that referenced
this pull request
Nov 30, 2024
Signed-off-by: Pablo Herrera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this image, the player was actually kicked not due to balance, but because someone else with perms joined and there was no longer room for the pleyer, ie: it was a priority kick. The current logic for messages makes no sense, anyone without perms will always get the "for balance" message.
Changed it so if the kick is for balance it shows the balance message, but priority kicks properly use the priority kick msg