Permit specifying world for default map variant #1457
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing this change however there are some differences to consider when comparing to ProjectAres.
In ProjectAres, the terrain module had more options that it currently does in present-day PGM, in that it was possible to specify both a world folder and to disable pre-match block physics. Further, in PGM we can define dimension in the terrain module, while ProjectAres moved this to the main map element as
dimension
, separate from the terrain module.The idea with this change is that we are able to define a
world
conditionally for certain versions, while avoiding an entirely new variant for a map. An example where this may be used is with the map Azure: Azure has path blocks in its original 1.12 map world, however we have simply NBT converted the map to be used on OCC 1.8. Preferably, we do not need to create an entirely new variant just to use the original world on relevant server versions.Alternatively to this PR, we could implement the world folder feature in the terrain module but given the pre-existing framework in place for variants this does seem more trivial.