Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit specifying world for default map variant #1457

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

calcastor
Copy link
Contributor

I am proposing this change however there are some differences to consider when comparing to ProjectAres.

In ProjectAres, the terrain module had more options that it currently does in present-day PGM, in that it was possible to specify both a world folder and to disable pre-match block physics. Further, in PGM we can define dimension in the terrain module, while ProjectAres moved this to the main map element as dimension, separate from the terrain module.

The idea with this change is that we are able to define a world conditionally for certain versions, while avoiding an entirely new variant for a map. An example where this may be used is with the map Azure: Azure has path blocks in its original 1.12 map world, however we have simply NBT converted the map to be used on OCC 1.8. Preferably, we do not need to create an entirely new variant just to use the original world on relevant server versions.

Alternatively to this PR, we could implement the world folder feature in the terrain module but given the pre-existing framework in place for variants this does seem more trivial.

Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be thought thru a bit more.

It creates an inconsistency between the default variant, where it can have a <world>folder</world> while the other variants aren't allowed to have that.

Ontop of that this creates inconsistencies with conditionals, as other map variants would not know about the world of the default variant, this was already an issue before with allowing slugs to be defined in the main section of the xml instead of within the variant

@calcastor calcastor marked this pull request as draft December 18, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants