Fix comment

PHILO-HE · Jun 19, 2024 · 04aaf92 · 04aaf92
1 parent 5420747
commit 04aaf92
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 14 deletions.
diff --git a/velox/docs/functions/spark/array.rst b/velox/docs/functions/spark/array.rst
@@ -166,6 +166,10 @@ Array Functions
     Returns the size of the array. Returns null for null input if `legacySizeOfNull`
     is set to false. Otherwise, returns -1 for null input.
 
+        SELECT size(array(1, 2, 3), true); -- 3
+        SELECT size(NULL, true); -- -1
+        SELECT size(NULL, false); -- NULL
+
 .. spark:function:: sort_array(array(E)) -> array(E)
 
     Returns an array which has the sorted order of the input array. The elements of array must

diff --git a/velox/docs/functions/spark/map.rst b/velox/docs/functions/spark/map.rst
@@ -46,3 +46,7 @@ Map Functions
 
     Returns the size of the input map. Returns null for null input if ``legacySizeOfNull``
     is set to false. Otherwise, returns -1 for null input.
+
+        SELECT size(map(array(1, 2), array(3, 4)), true); -- 2
+        SELECT size(NULL, true); -- -1
+        SELECT size(NULL, false); -- NULL
diff --git a/velox/functions/sparksql/Size.cpp b/velox/functions/sparksql/Size.cpp
@@ -39,20 +39,6 @@ struct Size {
     legacySizeOfNull_ = *legacySizeOfNull;
   }
 
-  template <typename TInput>
-  FOLLY_ALWAYS_INLINE bool callNullable(int32_t& out, const TInput* input) {
-    if (input == nullptr) {
-      if (legacySizeOfNull_) {
-        out = -1;
-        return true;
-      } else {
-        return false;
-      }
-    }
-    out = input->size();
-    return true;
-  }
-
   template <typename TInput>
   FOLLY_ALWAYS_INLINE bool callNullable(
       int32_t& out,
@@ -70,6 +56,7 @@ struct Size {
   }
 
  private:
+  // If true, returns -1 for null input. Otherwise, returns null.
   bool legacySizeOfNull_;
 };
 } // namespace