-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement config variable to allow iat to remain unchanged claim when refreshing a token #269
base: main
Are you sure you want to change the base?
Conversation
… refreshing a token
@mfn or @eschricker can you review it? |
Please allow me to find time, getting back ASAP |
I replied over at #268 (comment) |
I replied in #268 as well :) |
I am actually keen to set this to false by default in the interests of security, if the other maintainers are game. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually keen to set this to false by default in the interests of security, if the other maintainers are game.
I can, together with the context of #268 (comment) , agree to this.
I acknowledge:
- the sudden change in behaviour which next to no proper warning is very unfortunate
- in the interest of secure-by-default, the default should be
false
and match the current behaviour - the config comment, which likely will serve as the primordial documentation on this for the future, should be more clear about the security implications, more or less the scenario in the comment from @specialtactics I linked to
What do y'all think?
I agree with your thoughts there @mfn, and I guess to your point, we need to work on having some documentation there on that, since we are adding more functionality to this package, and I don't think we control the original docs? |
Description
Please see my issue #268. Implement possibility to keep iat unchanged during token refresh.
Checklist:
CHANGELOG.md