Skip to content

Commit

Permalink
GH Actions/label new PRs: use v1 floating tag
Browse files Browse the repository at this point in the history
Using `master` for action runners is bad practice (as it opens you up to unexpectedly moving to a new major containing breaking changes), but so far, the `srvaroa/labeler` action did not have a floating/moving `v1` tag.

This tag has now been added, so updating the workflow to use it.

The action has also tagged version `v1.7.2`, which should fix an issue I previously reported where tags were being removed, even though the config forbids this.

Refs:
* srvaroa/labeler 104
* srvaroa/labeler 110
* https://github.com/srvaroa/labeler/releases/tag/v1.7.2
  • Loading branch information
jrfnl committed Nov 11, 2023
1 parent 438357a commit 21faced
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/label-new-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

steps:
- name: Label new PRs
uses: srvaroa/labeler@master
uses: srvaroa/labeler@v1
env:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

Expand All @@ -41,7 +41,7 @@ jobs:
uses: actions/checkout@v3

- name: Verify changes to the labeling logic
uses: srvaroa/labeler@master
uses: srvaroa/labeler@v1
with:
use_local_config: true
fail_on_error: true
Expand Down

0 comments on commit 21faced

Please sign in to comment.