Tests: Fix libxml >= 2.12 compatibility

[asispts]

Description

I've updated the tests to support both libxml < 2.12 and >= 2.12.

Suggested changelog entry

Related issues/external references

Fixes #767

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
  • This change is only breaking for integrators, not for external standards or end-users.
• Documentation improvement

PR checklist

• I have checked there is no other PR open for the same change.
• I have read the Contribution Guidelines.
• I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
• I have added tests to cover my changes.
• I have verified that the code complies with the projects coding standards.
• [Required for new sniffs] I have added XML documentation for the sniff.

[jrfnl]

Thanks for working on this @asispts. Quick question: why did you change the regex delimiter from a backtick to # ? Is that necessary for libxml 2.12 or just a personal preference ?

[asispts]

It's just a personal preference, and because It's hard to see "`" in the regex string. I'll change it back to "`" if needed.

[jrfnl]

It's just a personal preference, and because It's hard to see "" in the regex string. I'll change it back to "" if needed.

Yes please. I'd like to evaluate the PR on the changes actually needed for libxml 2.12 and not get distracted/confused by unrelated changes.

[asispts]

Done

[jrfnl]

@asispts Thank you very much for working on this.
While it would have been nice to have a test with a ruleset which would consistently display three errors on both libxml < 2.12 as well as >= 2.12, I can live with this. The underlying code handling errors from libxml is still being tested well enough to safeguard its functionality.

Thank you @asispts for investigating and unblocking this issue.

@remicollet This PR should mean that once PHPCS 3.12.0 has been released, you can remove the previously added @requires ... tag from the test docblock in the Fedora test setup. (will be confirmed before release via PR #798)

[jrfnl]

@asispts In the changelog, this project likes to give credit where credit is due and that means it normally contains the full name + handle of the contributor. If that's okay with you, would you mind sharing your name ? If not, I'll just use your GitHub handle. Okay ?

[asispts]

@jrfnl Yeah, it’s "Asis Pattisahusiwa"

[jrfnl]

@asispts Thanks. Noted.