Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/7-getStoryDetails] 스토리 상세 조회 api #8

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

5jisoo
Copy link
Contributor

@5jisoo 5jisoo commented Jul 26, 2023

📌 이슈 번호

#7

📢 의논 사항

  • 이후 스토리 상세 페이지 디자인에 따른 변동 가능성 있을 것 같아요!
    • 특히 좋아요 부분!

- 이후 디자인에 따른 변동 가능성 있음.
@5jisoo 5jisoo changed the title #7 feat: 양방향 정리, 스토리 상세 조회 api [feature/7-getStoryDetails] 스토리 상세 조회 api Jul 26, 2023
@5jisoo 5jisoo self-assigned this Jul 26, 2023
@5jisoo 5jisoo linked an issue Jul 26, 2023 that may be closed by this pull request
8 tasks
@5jisoo 5jisoo changed the base branch from main to develop July 26, 2023 13:17
Copy link
Contributor

@JoongHyun-Kim JoongHyun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니닷~! 충돌 조금 생길 것 같군요ㅎㅎ..

@@ -24,7 +24,7 @@ repositories {
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-data-jdbc'
implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation 'org.springframework.boot:spring-boot-starter-oauth2-client'
// implementation 'org.springframework.boot:spring-boot-starter-oauth2-client'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳!

.map(comment -> new CommentResDto(comment))
.collect(Collectors.toList());

return StoryDetailResponseDto.builder()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder 패턴 굳입니다요!

Copy link
Contributor

@ri-naa ri-naa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!!😊

@lsn5963
Copy link
Member

lsn5963 commented Jul 26, 2023

양방향 관계를 정리하는 개념이 어려워보이네요 저도 공부 많이 해야겠습니다 수고하셧습니다!

@JoongHyun-Kim JoongHyun-Kim merged commit 1d8bc54 into develop Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] stories API
4 participants