-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flux ci #3
Fix flux ci #3
Conversation
@enjhnsn2 Remaining errors before this PR is good to go Rust problems: error: mutable borrow from immutable input(s)
--> kernel/src/platform/chip.rs:41:22
|
41 | fn mpu(&self) -> &mut Self::MPU;
| ^^^^^^^^^^^^^^
| and flux_support is not allowed to use Flux problems: error[E0999]: cannot access fields of opaque struct `flux_ptr::FluxPtr`
--> flux_support/src/flux_ptr.rs:19:9
|
19 | / FluxPtr {
20 | | inner: value as *mut u8,
21 | | }
| |_________^
error[E0999]: cannot access fields of opaque struct `flux_ptr::FluxPtr`
--> flux_support/src/flux_ptr.rs:34:9
|
34 | ptr.inner as u8
| ^^^^^^^^^
error[E0999]: cannot access fields of opaque struct `flux_ptr::FluxPtr`
--> flux_support/src/flux_ptr.rs:49:10
|
49 | (self.inner as usize) % rhs
| ^^^^^^^^^^
error[E0999]: cannot access fields of opaque struct `flux_ptr::FluxPtr`
--> flux_support/src/flux_ptr.rs:57:21
|
57 | inner: (self.inner as usize + rhs) as *mut u8,
| ^^^^^^^^^^ |
For the imports that use std |
As for the flux issues: if those functions aren't passing right because you need to access |
39e7ae5
to
b90ff3a
Compare
I have addressed your comments. I believe this PR is done and more work should be moved to further development. Only needs to wait on me to rebase the ring_buffer changes. Remaining work:
|
What legitimate Flux errors have popped up? The only flux changes (I think) should be providing implementations for trusted functions, which shouldn't raise errors. |
Once we resolve the above issues I'll merge |
There are only overflow errors. |
im testing ci