-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 마이페이지 메인 화면 구현 #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
@@ -27,4 +27,32 @@ extension CALayer { | |||
let rect = bounds.insetBy(dx: dxValue, dy: dxValue) | |||
shadowPath = UIBezierPath(rect: rect).cgPath | |||
} | |||
|
|||
func addBorder( | |||
_ arr_edge: [UIRectEdge], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컨벤션에 맞게 설정 부탁드립니다!
그리고 arr_edge말고 다른 파라미터명은 없을까요? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arr_edge -> edges 로 변경했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 로그인 파트에서 프로필 설정할 때 쓰였던 코드에 있기는 한데, 이건 테두리 없는 버전이라 다음과 같이 코드를 짰었어요.
교체하는 게 나으려나요?
private let pencilImageView = UIImageView(image: UIImage(named: "pencilCircle")).then {
$0.layer.borderColor = UIColor.background.cgColor
$0.layer.borderWidth = 2
$0.layer.cornerRadius = 16
$0.contentMode = .scaleAspectFit
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 이건 안바꾸셔도 괜찮을 것 같습니다!
저는 특정 부분만 border를 추가하고 싶어서 저 함수를 추가했어요!
|
||
import RxSwift | ||
|
||
class MyPageService: BaseService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅎㅎ..
class MyPageService: BaseService { | |
final class MyPageService: BaseService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!!
override func layoutSubviews() { | ||
super.layoutSubviews() | ||
containerView.roundCorners(corners: [.bottomLeft, .bottomRight], radius: 15) | ||
containerView.layer.addBorder([.bottom], color: .init(hex: 0xF2F3F4), width: 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#F2F3F4
는 UIColor.lightGray를 쓰시면 될 것 같습니다!
지금 보니 UIColor.lightGray색상도 바뀌었군요.. 같이 수정해주실 수 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다!!
} | ||
|
||
override init(reuseIdentifier: String?) { | ||
super.init(reuseIdentifier: reuseIdentifier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 띄어쓰기 이상해요!
import SnapKit | ||
import RxSwift | ||
import RxCocoa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import SnapKit | |
import RxSwift | |
import RxCocoa | |
import RxSwift | |
import RxCocoa | |
import SnapKit | |
import Then |
Conflicts: PLUB.xcodeproj/project.pbxproj
📌 PR 요약
마이페이지 메인 화면 구현
🌱 작업한 내용
🌱 PR 포인트
1. 모임 조회 API 호출 관련
모임 조회 API
를 동시에 4번 호출하게 됩니다.WAITING, ACTIVE, END, RECRUITING
플러빙이 비어있지 않을 때
만 섹션을 추가해줍니다.2. 섹션 접고 펴기 관련
header, cell, footer
3가지 영역으로 구성되어있습니다.roundCorner
를, footer에는 bottom에만roundCorner
를 적용시켰습니다.3. 미구현 부분
📸 스크린샷
RPReplay_Final1678732512.MP4
📮 관련 이슈