-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
246 update python functions to adhere to simpler standards and pre format data #269
Open
ymahlich
wants to merge
24
commits into
main
Choose a base branch
from
246-update-python-functions-to-adhere-to-simpler-standards-and-pre-format-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
246 update python functions to adhere to simpler standards and pre format data #269
ymahlich
wants to merge
24
commits into
main
from
246-update-python-functions-to-adhere-to-simpler-standards-and-pre-format-data
+1,336
−413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in `cd.Dataset.train_test_validate()` but can also be called as standalone function (`cd.train_test_validate()`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses all points raised in #246
Refactor / rewrite of
DatasetLoader
intoDataset
cd.Dataset
contains the following functions:dataset.format(data_type, ...)
: returns a formatted version of the datatype of interest. Currently supports ('transcriptomics', 'mutations', 'copy_number', 'proteomics', 'experiments', 'combinations', 'drug_descriptor', 'drugs', 'genes', 'samples')dataset.train_test_validate(args)
: splits the dataset into train, test & validation sets, and returns a@dataclass Split
object containing all three datasetsdataset.types()
: returns a list of data types present in the datasetdataset.save()
: saves the dataset object into a pickle filerewrite / addition of functions in coderdata:
cd.download(name, ...)
: refactor ofcd.download_by_prefix
that also allows forlocal_path
&exist_ok
arguments defining the directory the files should be downloaded into, and whether they should be overwritten if they already exist.cd.load(name, ...)
: returns acd.Dataset
object based on the dataset name given as argument. Also accepts parametersdirectory
(defines which directory contains the datafiles to be loaded) &from_pickle
(determines if a pickled Dataset, e.g. from Dataset.save() should be loaded).cd.list()
: returns a list of available datasets (based ondatasets.yml
in the root directory ofcoderdata
- potentially will be changed to a yaml that is stored in figshare in future builds)cd.version()
: returns version strings of the package and dataset