Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Commands.py #6

Open
wants to merge 2 commits into
base: Professor-99
Choose a base branch
from
Open

Conversation

Zinan100
Copy link

@Zinan100 Zinan100 commented Feb 7, 2022

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 7, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.14%.

Quality metrics Before After Change
Complexity 10.36 🙂 10.36 🙂 0.00
Method Length 113.16 🙂 112.33 🙂 -0.83 👍
Working memory 12.29 😞 12.29 😞 0.00
Quality 46.04% 😞 45.90% 😞 -0.14% 👎
Other metrics Before After Change
Lines 151 153 2
Changed files Quality Before Quality After Quality Change
DonLee_Robot_V2/Commands.py 46.04% 😞 45.90% 😞 -0.14% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
DonLee_Robot_V2/Commands.py start 15 🙂 278.95 ⛔ 13 😞 34.71% 😞 Try splitting into smaller methods. Extract out complex expressions
DonLee_Robot_V2/Commands.py help 0 ⭐ 169 😞 13 😞 55.82% 🙂 Try splitting into smaller methods. Extract out complex expressions
DonLee_Robot_V2/Commands.py about 0 ⭐ 90 🙂 13 😞 65.20% 🙂 Extract out complex expressions
DonLee_Robot_V2/Commands.py sub 0 ⭐ 81 🙂 13 😞 66.51% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant