fix for kinetic

[furushchev]

No description provided.

[dirk-thomas]

@ablasdel @thedash Ping to the maintainers...

[UltronDestroyer]

I haven't maintained this for a year or so. Not sure who is going to take it over.

[dirk-thomas]

You are currently still listed as the maintainer of this package (

rqt_pr2_dashboard/package.xml

Line 9 in f2fd1d3

<maintainer email="[email protected]">Devon Ash</maintainer>

). So e.g. any notification email from the buildfarm is being sent to you.

[DLu]

I have reviewed this PR and approve, but commenting is all I'm authorized for. It'd be best if it was tested in other distros besides kinetic, but I'm guessing it'd work.

Note: Releasing this package for kinetic would rely on PR2/pr2_power_drivers#67

[furushchev]

@DLu Thank you for review! I also checked that this works on indigo.

[UltronDestroyer]

@dirk-thomas Out of my hands now. AFAIK there is no official PR2 maintainership since Scott Hassan ceased the funding for the PR2 support. The community unfortunately will have to find someone else to take maintainership/release responsibility over them as I'm unable to at the moment.

[k-okada]

@TheClearpathDash we have proposed the initiative to support this kind of packages at roscon 2017. See
video: https://vimeo.com/236129109#t=34m30s
slides: https://roscon.ros.org/2017/presentations/ROSCon%202017%20Lightning%20113.pdf

and I have start writing a draft of this procedure at
ros-infrastructure/rep#150 (https://github.com/k-okada/rep/blob/0d5b63cc04ba945fec73650f9453d576b939a67a/rep-0152.rst ).

If you're ok, please look at these ticket and add @k-okada to admin/write manber of these repositories.
PR2/pr2_power_drivers#68
#20

[k-okada]

also please add me to pr2_power_drivers-release and rqt_pr2_dashboard-release repositories.

[v4hn]

+1 for the pull-request here.

[awesomebytes]

+1 for the PR, looks good to me.

[k-okada]

Merged, It seems I have write permission, but I do not have admin permission...