Skip to content

Commit

Permalink
Remove divided by three in the robust kernel (#437)
Browse files Browse the repository at this point in the history
* Remove div 3

* Make it consistent for the C++ library
  • Loading branch information
tizianoGuadagnino authored Jan 29, 2025
1 parent 77dd5e5 commit c9f6931
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cpp/kiss_icp/pipeline/KissICP.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ KissICP::Vector3dVectorTuple KissICP::RegisterFrame(const std::vector<Eigen::Vec
local_map_, // voxel_map
initial_guess, // initial_guess
3.0 * sigma, // max_correspondence_dist
sigma / 3.0); // kernel
sigma); // kernel

// Compute the difference between the prediction and the actual estimate
const auto model_deviation = initial_guess.inverse() * new_pose;
Expand Down
2 changes: 1 addition & 1 deletion python/kiss_icp/kiss_icp.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def register_frame(self, frame, timestamps):
voxel_map=self.local_map,
initial_guess=initial_guess,
max_correspondance_distance=3 * sigma,
kernel=sigma / 3,
kernel=sigma,
)

# Compute the difference between the prediction and the actual estimate
Expand Down

0 comments on commit c9f6931

Please sign in to comment.