fix deleting password from profile data

PROCOLLAB-github · Oct 28, 2023 · fc01fbc · fc01fbc
1 parent 1a0ce91
commit fc01fbc
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/partner_programs/views.py b/partner_programs/views.py
@@ -84,6 +84,12 @@ def post(self, request, *args, **kwargs):
                 data={"detail": "You need to pass an email address."},
                 status=status.HTTP_400_BAD_REQUEST,
             )
+        password = data.get("password")
+        if not password:
+            return Response(
+                data={"detail": "You need to pass a password."},
+                status=status.HTTP_400_BAD_REQUEST,
+            )
 
         user_fields = (
             "first_name",
@@ -106,18 +112,11 @@ def post(self, request, *args, **kwargs):
                 status=status.HTTP_400_BAD_REQUEST,
             )
 
-        password = data.get("password")
-        del data["password"]
-        if not password:
-            return Response(
-                data={"detail": "You need to pass a password."},
-                status=status.HTTP_400_BAD_REQUEST,
-            )
         user.set_password(password)
         user.save()
 
         user_profile_program_data = {
-            k: v for k, v in data.items() if k not in user_fields
+            k: v for k, v in data.items() if k not in user_fields and k != "password"
         }
         PartnerProgramUserProfile.objects.create(
             partner_program_data=user_profile_program_data,