Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependency: psutil #377

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

gdrosos
Copy link
Contributor

@gdrosos gdrosos commented Aug 12, 2023

Summary

This pull request removes the unused dependency psutil from the setup.py configuration file . This detection and removal is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The psutil library was introduced in a6d60a7. However, an examination of the current codebase revealed that it is not used within the project. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

  • Removed the psutil dependency from the setup.py file.

Impact

  • Reduced package size: Eliminating this unused dependency will decrease the overall size of the installed packages.

  • Simplified dependency tree: A leaner list of dependencies aids in more straightforward project maintenance and faster installations.

@gdrosos
Copy link
Contributor Author

gdrosos commented Aug 27, 2023

Hello @rickecon, @jdebacker

I hope this message finds you well. We are currently engaged in a research project focused on optimizing projects by identifying and eliminating unnecessary dependencies. Your insights and expertise as maintainers would greatly contribute to our research efforts.

Could you please take a moment to review these changes? Your input would be highly valuable to us.

Thank you for your consideration!

@jdebacker
Copy link
Member

@gdrosos I saw an error in the units tests run under CI with this PR. I've fixed those in PR #378.

Can you sync to the master branch and then this PR should pass tests and I will merge.

Thanks!

@gdrosos
Copy link
Contributor Author

gdrosos commented Sep 5, 2023

Thanks @jdebacker, I just synced the fork to the master branch

@jdebacker
Copy link
Member

Thanks for this PR @gdrosos! Merging.

@jdebacker jdebacker merged commit a8bd0ed into PSLmodels:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants