-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update demographics.py and PolicyEngine #57
Conversation
@jdebacker @nikhilwoodruff. The
|
OK @rickecon - think this is getting somewhere: the package installs are now working, and the microdata tests passing, but the
So I think the Also, here's the shape of each item in the tax function parameter dictionary:
|
Codecov ReportBase: 70.06% // Head: 72.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 70.06% 72.91% +2.84%
==========================================
Files 4 4
Lines 147 144 -3
==========================================
+ Hits 103 105 +2
+ Misses 44 39 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Just a few thoughts before our next OG call:
I'd recommend merging this PR without the Windows and docs build test passes because neither of them represent a regression really (the docs just won't get updated rather than being taken down), and also because I think this PR overlaps/aids some of the others (e.g. I think it fixes #55, and resolves pretty much all PolicyEngine-UK-related issues in other PRs). |
@nikhilwoodruff. I discovered that one reason my earlier runs of the model were breaking in the However, I now get the following error when running on my machine in the
|
@rickecon - I had no idea about the M1-optimised Python distribution, interesting! (I think we might be on the same Mac device?). Hmm, I thought I'd removed the |
This PR is mainly to update
demographics.py
to use UN data. However, I also added a bunch of other related updates. This PR does the following:demographics.py
to use the UN data portal to get UK demographic data.calibrate.py
to allow for demographics..csv
files tooguk/data/demographic/
. This files allow fordemographics.py
to have the option to not download the data from the UN data portal.get_micro_data.py
andtest_get_micro_data.py
withPolicyEngine
references instead ofOpenFisca
.environment.yml
andsetup.py
.run_oguk.py
with more consistent specification, and updated references fromopenfisca
topolicyengine
..gitignore
,README.md
,demographics.rst
,get_micro_data.rst
, andtax_functions.md
.pyproject.toml
which was just a reference to the black package.CHANGELOG.md
and updates the version number insetup.py
.deploy_docs.yml
,docs_check.yml
, andbuild_and_test.yml
.cc: @jdebacker