-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Tulip Solver #393
Switch to Tulip Solver #393
Conversation
Relevant changes to the calculations can be found here. There are no major changes in output when compared to taxcalc 3.0.0. |
Thanks @andersonfrailey. It looks to me like this is based on the early version of notes I made regarding Tulip. However, if you work through the full post of #381 you will find two major additional improvements:
If you scroll toward the bottom of #381 you will find a drop-in replacement solver.jl function that implements all of the changes:
If you use this code (it should be easy to replace what you have now with this) I think you will find that it (a) reaches optimality easily, (b) it is MUCH faster still, and (c) it is more stable numerically. |
Last commit makes the changes suggested by @donboyd5 |
If there are no more comments, I'll merge this at the end of the weekend. |
Out of curiosity, what was runtime after the latest round of changes? |
@MattHJensen running the full make script takes about 30 minutes now! |
This PR is in response to issue #381. It switches us over to the Tulip solver for the stage 2 process. When running the scripts this morning it took about an hour and a half to create weights for both the PUF and CPS, compared to the 24+ hours it took last time I created the weights with our current solver. I'll post results comparisons in a followup comment.
cc @donboyd5