Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped installation instructions & Software Dependencies pages with Docker-first approach #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Asp-irin
Copy link

@Asp-irin Asp-irin commented Feb 1, 2025

📋Changes made:

  • Restructured installation guide to highlight Docker as the preferred method
  • Added clear paths for both Docker and manual setup approaches
  • Updated references to match Software Dependencies guide steps (7, 8, 9)
  • Enhanced documentation flow and readability

✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

Summary by CodeRabbit

  • Documentation
    • Revamped the installation guide with clear, step-by-step instructions for setting up the development environment using both a Dockerized approach and a Manual process.
    • Updated the dependencies guide with enhanced formatting and explicit verification steps for required and optional software, improving overall clarity and usability.
    • Introduced a new section for building and running Maven projects through the CLI with detailed commands.
    • Modified UI repository setup instructions to allow for flexible application access at http://localhost:{PORT} based on user-defined configurations.

Copy link

coderabbitai bot commented Feb 1, 2025

Walkthrough

The pull request revises the developer guide documentation. The installation instructions are now presented as a detailed, step-by-step guide organized into three sections: Software Dependencies, Infrastructure Setup, and Application Setup. Each section explains two installation paths—Dockerized and Manual—for clarity. Additionally, the software dependencies document has been reformatted with updated markdown header levels and newly added verification commands and details outlining optional tools. No changes were made to public entity declarations.

Changes

Files Change Summary
developer-guide/development-environment-setup/installation-instructions/README.md Restructured content into a step-by-step guide under "Software Dependencies," "Infrastructure Setup," and "Application Setup," with distinct Dockerized and Manual installation paths.
developer-guide/development-environment-setup/software-dependencies.md Reformatted by updating section header levels, adding software verification commands, and clarifying optional installations for Docker, MySQL/MongoDB, and Redis.
developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md Introduced a new section "Through CLI" with step-by-step instructions for building and running a Maven project from the command line.
developer-guide/development-environment-setup/installation-instructions/for-ui-repositories.md Updated final step to indicate the application can be accessed at http://localhost:{PORT}, allowing for flexible port configurations.

Possibly related PRs

Poem

I hopped through docs with curious delight,
Restructuring steps, making guidance feel light.
Docker or manual, each path shines so clear,
My ears twitch with joy as instructions appear.
A rabbit celebrates updates with a cheerful cheer! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md (1)

17-19: Adjust Unordered List Indentation to Resolve MD007

The markdown linter reports that the unordered list items in this section are indented by 3 spaces, while the expected indent is 0. Removing the extra spaces will help maintain consistency and avoid linting warnings.

-   * Navigate to your project directory using the `cd` command.
-   * Use the Maven command `mvn clean install` to build your project.
-   * To run your Java application, use `mvn spring-boot:run -DENV_VAR=local`. Ensure the Redis server is open during the run.
+* Navigate to your project directory using the `cd` command.
+* Use the Maven command `mvn clean install` to build your project.
+* To run your Java application, use `mvn spring-boot:run -DENV_VAR=local`. Ensure the Redis server is open during the run.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

17-17: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


18-18: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


19-19: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d782a1 and 8f7f261.

📒 Files selected for processing (2)
  • developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md (1 hunks)
  • developer-guide/development-environment-setup/installation-instructions/for-ui-repositories.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md

17-17: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


18-18: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


19-19: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)

🔇 Additional comments (2)
developer-guide/development-environment-setup/installation-instructions/for-ui-repositories.md (1)

33-33: Flexible Port Instruction Enhances Clarity

The updated instruction now directs users to access the application using a placeholder for the port ({PORT}), with a reference to the AMRIT documentation for the actual value. This improves flexibility over having a hardcoded URL and aligns well with the updated, Docker-first installation approach detailed in the overall documentation.

developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md (1)

15-20: New "Through CLI" Section Added

The new section provides a clear, step-by-step procedure for building and running the Maven project via the command line. This addition nicely complements the existing IDE-centric instructions and enhances user flexibility.

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

17-17: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


18-18: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


19-19: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md (1)

47-47: Verify Consistency of Swagger UI Instructions in Run Configuration
The added instruction at line 47 to load the Swagger UI after running the configuration in STS/Eclipse reinforces user guidance. Please confirm that repeating this step in multiple sections (CLI and IDE configurations) is intentional and consistent with the overall documentation style.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f7f261 and d45ae64.

📒 Files selected for processing (1)
  • developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md (3 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md

17-17: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


18-18: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


19-19: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


20-20: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)

🔇 Additional comments (2)
developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md (2)

15-21: Add "Through CLI" Section and Adjust Markdown List Indentation
The new "Through CLI" instructions are clear and provide a straightforward guide for CLI-based Maven builds and runs. However, the unordered list items (lines 17–20) are indented with three spaces, which triggers MD007 warnings in markdownlint. For consistency with the rest of the document—and to adhere to the lint rule—consider removing the extra indentation so that the bullet points align flush with the left margin.

-   * Navigate to your project directory using the `cd` command.
-   * Use the Maven command `mvn clean install` to build your project.
-   * To run your Java application, use `mvn spring-boot:run -DENV_VAR=local`. Ensure the Redis server is open during the run.
-   * Once the run is complete, load `http://localhost:{PORT}/swagger-ui.html#!/`, where PORT is defined in the [AMRIT documentation](https://github.com/PSMRI/AMRIT/blob/main/README.md).
+* Navigate to your project directory using the `cd` command.
+* Use the Maven command `mvn clean install` to build your project.
+* To run your Java application, use `mvn spring-boot:run -DENV_VAR=local`. Ensure the Redis server is open during the run.
+* Once the run is complete, load `http://localhost:{PORT}/swagger-ui.html#!/`, where PORT is defined in the [AMRIT documentation](https://github.com/PSMRI/AMRIT/blob/main/README.md).
✅ Verification successful

Action: Adjust Markdown List Indentation in CLI Instructions

The diff provided is accurate—remove the extra three spaces before the bullet list items so they align flush with the left margin to prevent MD007 warnings.

  • Update the file developer-guide/development-environment-setup/installation-instructions/for-api-repositories.md so that the list items start at the beginning of the line (no extra indentation).
🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found

🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

17-17: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


18-18: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


19-19: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


20-20: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


66-66: Standardize Bullet List Formatting in VS Code Instructions
In the Visual Studio Code section, the bullet point at line 66 is indented with extra spaces. For consistency with the "Through CLI" section (after adjustment) and other parts of the document, consider removing the unnecessary indentation.

-   * Once the run is complete, load `http://localhost:{PORT}/swagger-ui.html#!/`, where PORT is defined in the [AMRIT documentation](https://github.com/PSMRI/AMRIT/blob/main/README.md).
+* Once the run is complete, load `http://localhost:{PORT}/swagger-ui.html#!/`, where PORT is defined in the [AMRIT documentation](https://github.com/PSMRI/AMRIT/blob/main/README.md).
✅ Verification successful

Standardize Bullet List Formatting in VS Code Instructions
I've reviewed the documentation file and confirmed that the Visual Studio Code section’s bullet at line 66 is indented with extra spaces compared to the "Through CLI" section. Removing the extra indentation—as suggested—will standardize the formatting across the document.

🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant