updating ci properties #60
Conversation
adding tmReferCheckValue
adding mmucentral server and tm
WalkthroughThe changes involve the addition of several new configuration entries to the Changes
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/main/environment/common_ci.properties (2)
42-44: Consider organizing related properties togetherThe new server URLs seem related to case sheet operations but are placed between unrelated properties. Consider grouping them with other similar endpoint configurations for better maintainability.
- mmucentralserver = @env.MMU_CENTRAL_SERVER@/common/get/Case-sheet/centralServerTMCaseSheet - - tmCentralServer = @env.TM_CENTRAL_SERVER@/common/get/Case-sheet/printDataConsider moving these properties near other API endpoint configurations at the top of the file.
72-72: Document the purpose of tmReferCheckValueThe property
tmReferCheckValue=TMlacks documentation explaining its purpose and usage. Consider adding a comment to clarify:
- What does this value represent?
- Where is it used?
- Why is "TM" the default value?
+ # Value used to identify TeleMedicine referrals in the system tmReferCheckValue=TM
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
src/main/environment/common_ci.properties(2 hunks)
🔇 Additional comments (1)
src/main/environment/common_ci.properties (1)
42-42: Verify the new environment variables are properly configured
The new properties depend on environment variables MMU_CENTRAL_SERVER and TM_CENTRAL_SERVER. Ensure these are properly configured in all deployment environments.
Also applies to: 44-44
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
mmucentralserver: Endpoint for case sheet retrieval.tmCentralServer: Endpoint for printing case sheet data.tmReferCheckValue: Static value for reference checks.