changing env.variable #65
Conversation
adding tmReferCheckValue
adding mmucentral server and tm
COOMON_API MMU_API TM_API
WalkthroughThe pull request involves modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/main/environment/common_ci.properties (2)
Line range hint
9-74: Document the environment variable changes.The standardization of environment variables (removing
_BASE_URLsuffix) is a breaking change that affects deployment configurations. Please:
- Update deployment documentation
- Add migration notes
- Notify the DevOps team
32-35: Remove commented-out "not required" annotations.The comments
# not requirednext to TC specialist slot endpoints are confusing. If these endpoints are truly not required, consider removing them entirely. Otherwise, remove the misleading comments.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/environment/common_ci.properties(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (3)
src/main/environment/common_ci.properties (3)
80-80: No functional change in logging configuration.The logging file name property appears unchanged despite being marked as modified. This might be a whitespace or line-ending change.
26-26: Verify the impact of MMU_API environment variable change.The change from
MMU_API_BASE_URLtoMMU_APIaffects data synchronization and file management endpoints. This standardization needs careful verification.Also applies to: 29-29, 49-49, 52-52, 74-74
✅ Verification successful
Environment variable migration successfully completed ✅
The migration from
MMU_API_BASE_URLtoMMU_APIhas been properly implemented:
- No remaining references to the old variable exist in the codebase
- New variable is consistently used across all endpoints in common_ci.properties
- Changes are properly isolated to the configuration file
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining instances of MMU_API_BASE_URL to ensure complete migration echo "Checking for any remaining MMU_API_BASE_URL references..." rg "MMU_API_BASE_URL" --type properties # Search deployment scripts and documentation for environment variable definitions echo "Checking deployment configurations..." fd -e yaml -e yml -e sh -e md -X rg "MMU_API(_BASE_URL)?"Length of output: 344
Script:
#!/bin/bash # Search for both old and new variable names in all files echo "Checking all files for environment variable references..." rg "MMU_API_BASE_URL" rg "@env\.MMU_API@" # Search specifically in configuration and properties files echo "Checking configuration files..." fd -e properties -e xml -e conf -e config -e env -X rg -l "(MMU_API_BASE_URL|@env\.MMU_API@)" # Check deployment and environment configuration directories echo "Checking deployment and environment directories..." fd -t d "deploy|environment|config" -X rg -l "(MMU_API_BASE_URL|@env\.MMU_API@)"Length of output: 1182
9-9: Verify the impact of COMMON_API environment variable change.The change from
COMMON_API_BASE_URLtoCOMMON_APIaffects multiple critical endpoints related to beneficiary management and registration. This standardization needs careful verification.Also applies to: 13-13, 15-15, 17-17, 21-21, 23-23, 38-38, 46-46
✅ Verification successful
API environment variable change successfully standardized
The migration from COMMON_API_BASE_URL to COMMON_API is complete and consistent across all environment configurations. No remnants of the old variable name were found, and all affected endpoints are properly using the new format.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining instances of COMMON_API_BASE_URL to ensure complete migration echo "Checking for any remaining COMMON_API_BASE_URL references..." rg "COMMON_API_BASE_URL" --type properties # Search deployment scripts and documentation for environment variable definitions echo "Checking deployment configurations..." fd -e yaml -e yml -e sh -e md -X rg "COMMON_API(_BASE_URL)?"Length of output: 356
Script:
#!/bin/bash # Search for both old and new variable names in all relevant files echo "Searching for COMMON_API_BASE_URL..." rg "COMMON_API_BASE_URL" echo -e "\nSearching for COMMON_API environment variable..." rg "@env\.COMMON_API@" echo -e "\nSearching for properties files..." fd ".*\.properties$" -x cat {} \; -x echo "---" echo -e "\nChecking Java files for API URL usage..." ast-grep --pattern 'getProperty("$_URL")'Length of output: 17638
|
|
||
| ## TC specialist slot booking, # not required | ||
| tcSpecialistSlotBook=@env.TM_API_BASE_URL@/schedule/bookSlot | ||
| tcSpecialistSlotBook=@env.TM_API@/schedule/bookSlot |
There was a problem hiding this comment.
💡 Codebase verification
Environment variable standardization is incomplete
The migration to TM_API is only partially implemented:
- Only CI environment (
common_ci.properties) uses@env.TM_API@ - DEV and TEST environments use placeholder URLs
- Example environment uses hardcoded IP addresses
- UAT environment is missing these configurations entirely
🔗 Analysis chain
Verify the impact of TM_API environment variable change.
The change from TM_API_BASE_URL to TM_API affects telemedicine specialist slot management. This standardization needs careful verification.
Also applies to: 35-35
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining instances of TM_API_BASE_URL to ensure complete migration
echo "Checking for any remaining TM_API_BASE_URL references..."
rg "TM_API_BASE_URL" --type properties
# Search deployment scripts and documentation for environment variable definitions
echo "Checking deployment configurations..."
fd -e yaml -e yml -e sh -e md -X rg "TM_API(_BASE_URL)?"
Length of output: 340
Script:
#!/bin/bash
# Search for both old and new environment variable references
echo "Searching for TM_API_BASE_URL references..."
rg "TM_API_BASE_URL"
echo -e "\nSearching for TM_API references..."
rg "TM_API[^_]" -A 1
echo -e "\nChecking configuration and properties files..."
fd -e properties -e conf -e config -e env -e yaml -e yml
Length of output: 1010
Script:
#!/bin/bash
# Check slot booking related properties across all environment files
echo "Checking slot booking properties across environments..."
for file in src/main/environment/common_*.properties; do
echo -e "\nFile: $file"
rg "tcSpecialist(SlotBook|SlotCancel)" "$file" -A 1
done
Length of output: 2252
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit