Scheduler-UI-NEXT from develop to master Code push regarding CI Build Configurations and some fixes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change in pacakage.lock.json final in fork branch * change in recapture method in camera comp --------- Co-authored-by: Parth Kothari <[email protected]>
drtechie
reviewed
May 14, 2024
| @@ -29,7 +29,7 @@ const COMMON_API_OPEN = '<%= COMMON_API_BASE %>'; | |||
| const COMMON_API = '<%= COMMON_API_BASE %>'; | |||
| const SCHEDULER_API = '<%= SCHEDULER_API_BASE %>'; | |||
| const TM_API = '<%= TM_API_BASE %>'; | |||
|
|
|||
| const MMU_API = `http://${IP}:8080/mmuapi-v1.0/`; | |||
There was a problem hiding this comment.
This doesn't look right.
http and port numbers shouldn't be here.
There was a problem hiding this comment.
Even the version of the mmu API
There was a problem hiding this comment.
@drtechie HI Mithun, updated as per comments, Please check
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduler-UI-NEXT from develop to master Code push regarding CI Build Configurations and some fixes