Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various features to flash analysis #24072

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

alexcekay
Copy link
Member

Solved Problem

There has been feedback regarding the FLASH analysis tool. This PR adds several of the requested features.

  • Use an updated version of bloaty
  • Show the FLASH diff directly, without the user having to scroll through the bloaty output
  • Don't show a comment for small changes
  • The analysis shall also work if the FLASH overflows

Solution

  • To use an updated bloaty version and return the diff to the GH action an adaption of the bloaty-action was required. These changes can be found here: https://github.com/PX4/bloaty-action
  • The action itself has been updated to show the diff and not post a comment if the diff is too small.
  • To avoid no ELF being created due to a FLASH overflow (and thus no option to do the analysis), a new flash-analysis board has been added to v5x and v6x which fakes a large FLASH.

Test coverage

@alexcekay alexcekay marked this pull request as ready for review December 4, 2024 12:29
Copy link
Contributor

@mrpollo mrpollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!

I left some comments, mainly focused on readability/maintainability for whoever comes after us and tries to figure this out

.github/workflows/flash_analysis.yml Outdated Show resolved Hide resolved
.github/workflows/flash_analysis.yml Outdated Show resolved Hide resolved
.github/workflows/flash_analysis.yml Outdated Show resolved Hide resolved
.github/workflows/flash_analysis.yml Show resolved Hide resolved
.github/workflows/flash_analysis.yml Show resolved Hide resolved
@PX4 PX4 deleted a comment from github-actions bot Dec 6, 2024
@mrpollo mrpollo force-pushed the pr-flash-analysis-features branch from 62e95db to 12d68ba Compare December 9, 2024 16:09
@alexcekay alexcekay requested a review from mrpollo December 9, 2024 16:48
Copy link
Contributor

@niklaut niklaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's get this in.

@alexcekay alexcekay enabled auto-merge (squash) December 10, 2024 09:15
@alexcekay alexcekay merged commit f9ecc0f into main Dec 10, 2024
36 of 38 checks passed
@alexcekay alexcekay deleted the pr-flash-analysis-features branch December 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants