Expect radians for DO_GIMBAL_MANAGER_PITCHYAW msg

[gillamkid]

Expect values to be in radians for the DO_GIMBAL_MANAGER_PITCHYAW msg (units are specified as radians in the MAVLINK message definition)

note: QGC is also setting the message fields using degrees when it should be using radians. The PR for that fix can be seen here: mavlink/qgroundcontrol#12232

Sponsor

This contribution was sponsored by Firestorm

[TSC21]

The command is actually correct: MAV_CMD_DO_GIMBAL_MANAGER_PITCHYAW. What is confisuing is why GIMBAL_MANAGER_SET_PITCHYAW uses the angles in rads and the command is using the angles in degrees, This is clearly a protocol mistake that lead to a misunderstanding. @hamishwillee FYI we probably should update this at the MAVLink level. Closing this for now

[hamishwillee]

Thanks @TSC21 - questions about gimbal message design should first be addressed to @julianoes - but this stuff is all implemented everywhere, so unlikely can be changed now.

[julianoes]

My thinking was that a command might be hand-crafted as part of a mission, and therefore I made it more intuitive. The rest is more of a programmatic API where we usually use radians. So while I had my reasons, I agree that it isn't necessarily intuitive and can catch you off guard. I believe it is documented correctly though, and it's implemented in various places this way, so unlikely to change.