Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gz model for quadtailsitter #65

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

Perrrewi
Copy link
Contributor

@Perrrewi Perrrewi commented Nov 14, 2024

Solved Problem
Transferring models from gazebo classic to gz. Added airspeed sensor as well. Tuned the AdvancedLiftDrag plugin to make sure the vehicle flies sufficiently good.

Fixes #23602

Test Coverage
It was tested on Ubuntu 22.04 using QGroundControl

Context
Before tuning:
Screenshot from 2024-11-14 14-16-48
Screenshot from 2024-11-14 14-17-01

After tuning:
Screenshot from 2024-11-14 14-18-02
Screenshot from 2024-11-14 14-18-07

There is a former pr about this, which was reverted: #50

Associated PR's

@hamishwillee
Copy link

Awesome, when this goes in, can we mirror it in the docs.

This would be an update to these places:

And maybe a simulation section at the end of https://docs.px4.io/main/en/frames_vtol/tailsitter.html

@Perrrewi
Copy link
Contributor Author

Made a draft for the description as well: PX4/PX4-user_guide#3469

Copy link
Contributor

@Claudio-Chies Claudio-Chies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me, I added a small formatting fix.
It might be worth a look at placing the meshes for the props in a separate folder, as multiple models like the advanced_plane or px4vision also use the same mesh, and we have the same file multiple times across different models.

models/airspeed/model.config Outdated Show resolved Hide resolved
models/quadtailsitter/model.config Outdated Show resolved Hide resolved
@Claudio-Chies Claudio-Chies force-pushed the pr-gz-sim-quadtailsitter branch from 8d75edc to 30e553d Compare December 2, 2024 14:31
@Claudio-Chies Claudio-Chies merged commit 019f63e into main Dec 2, 2024
4 checks passed
@Claudio-Chies Claudio-Chies deleted the pr-gz-sim-quadtailsitter branch December 2, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants