Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and Updates #24

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Bug fixes and Updates #24

merged 3 commits into from
Apr 26, 2024

Conversation

hypherionmc
Copy link
Collaborator

@hypherionmc hypherionmc commented Apr 25, 2024 •
edited
Loading

This PR is aimed at fixing the following issues:

  1. Unsupported class file major version, caused by Java 21 and ASM - Fixes Unsupported class file major version 65 #23
  2. Adds initial support for NeoForge, with a dedicated container. Not fully tested, so could have bugs - Addresses Forge and NeoForge #21
  3. Adds better detection for files. Now detects the newest file, with the shortest name, instead of just the shortest - Fixes MergeJars doesnt look for latest build, can grab old builds #12

I also updated the dependencies and the gradle version. There was a CVE in zip4j which has been addressed with this PR

(I tried to follow the current implementations, until we get time to do the proper rewrite)

@hypherionmc hypherionmc requested a review from Ran-Mewo April 25, 2024 17:47
@hypherionmc hypherionmc changed the title Fix Class Version Errors on 1.20.5 and add initial NeoForge Support Bug fixes and Updates Apr 25, 2024
@Ran-Mewo Ran-Mewo merged commit 40b980e into main Apr 26, 2024
@hypherionmc hypherionmc deleted the patch/1.20.5 branch April 26, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ran-Mewo Ran-Mewo Awaiting requested review from Ran-Mewo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsupported class file major version 65 MergeJars doesnt look for latest build, can grab old builds
2 participants
@hypherionmc @Ran-Mewo