feat!: Unify include types #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deduplicates types where includes are possible on API responses with those that are the same resource but no includes come back. Includes are optional on the type and thus can be used interchangeably BREAKING CHANGE: Include types are renamed to replace their non-include variant, see UPGRADING.md for migration details.
vifer
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deduplicates types where includes are possible on API responses with those that are the same resource but no includes come back.
Includes are optional on the type and thus can be used interchangeably
Note the diff is rather large due to a refactor in notification handling as part of this change, the files are now renamed to match the resource rather than the event, overall this doesn't impact the end user as the package is still the same 👍
BREAKING CHANGE: Include types are renamed to replace their non-include variant, see UPGRADING.md for migration details.