!feat: Improved type definitions #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewCreateSubscriptionChargeItemsSubscriptionsSubscriptionsCatalogItem -> NewCreateSubscriptionChargeItemsSubscriptionsCatalogItem NewPreviewSubscriptionChargeItemsSubscriptionsSubscriptionsCatalogItem -> NewPreviewSubscriptionChargeItemsSubscriptionsCatalogItem
PreviewTransaction -> PreviewTransactionCreate PreviewTransactionRequest -> PreviewTransactionCreateRequest CountryAndZipPostalCode -> TransactionPreviewByAddress CountryAndZipPostalCodeItems -> TransactionPreviewByAddressItems NewCountryAndZipPostalCodeItemsTransactionsCatalogItem -> NewTransactionPreviewByAddressItemsTransactionsCatalogItem NewCountryAndZipPostalCodeItemsTransactionsNonCatalogPriceForAnExistingProduct -> NewTransactionPreviewByAddressItemsTransactionsNonCatalogPriceForAnExistingProduct NewCountryAndZipPostalCodeItemsTransactionsNonCatalogPriceAndProduct -> NewTransactionPreviewByAddressItemsTransactionsNonCatalogPriceAndProduct IPAddress -> TransactionPreviewByIP IPAddressItems -> TransactionPreviewByIPItems NewIPAddressItemsTransactionsCatalogItem -> NewTransactionPreviewByIPItemsTransactionsCatalogItem NewIPAddressItemsTransactionsNonCatalogPriceForAnExistingProduct -> NewTransactionPreviewByIPItemsTransactionsNonCatalogPriceForAnExistingProduct NewIPAddressItemsTransactionsNonCatalogPriceAndProduct -> NewTransactionPreviewByIPItemsTransactionsNonCatalogPriceAndProduct ExistingCustomerPaddleIDs -> TransactionPreviewByCustomer ExistingCustomerPaddleIDsItems -> TransactionPreviewByCustomerItems NewExistingCustomerPaddleIDsItemsTransactionsCatalogItem -> NewTransactionPreviewByCustomerItemsTransactionsCatalogItem NewExistingCustomerPaddleIDsItemsTransactionsNonCatalogPriceForAnExistingProduct -> NewTransactionPreviewByCustomerItemsTransactionsNonCatalogPriceForAnExistingProduct NewExistingCustomerPaddleIDsItemsTransactionsNonCatalogPriceAndProduct -> NewTransactionPreviewByCustomerItemsTransactionsNonCatalogPriceAndProduct
Credit -> Money Charge -> Money
PreviewSubscriptionRequest -> PreviewSubscriptionUpdateRequest
vijayasingam-paddle
approved these changes
Jul 26, 2024
davidgrayston-paddle
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve on some type definitions where the originally generated types were too generic and don't work well in a single package scope.
This is broken out from a larger generation but should be isolated to just these changes.
BREAKING CHANGE: Type have been renamed or consolidated.