Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/Fix overview section #2

Merged
merged 3 commits into from
May 7, 2024
Merged

docs/Fix overview section #2

merged 3 commits into from
May 7, 2024

Conversation

vifer
Copy link
Collaborator

@vifer vifer commented May 7, 2024

No description provided.

@vifer vifer requested review from alecsammon and mikeymike May 7, 2024 15:12
@vifer vifer self-assigned this May 7, 2024
@vifer vifer requested a review from a team as a code owner May 7, 2024 15:13
@vifer vifer added the norelease label May 7, 2024
@vifer vifer enabled auto-merge (squash) May 7, 2024 15:14
addresses.go Outdated
@@ -1,4 +1,9 @@
//
Copy link
Contributor

@alecsammon alecsammon May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for goland

I don't think it's valid.

(I was wrong - it does work)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I think the only thing that is needed is the line break between the comment and the package paddle

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a single line break seams to be what mockery does

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ can confirm a line break does seem to do the trick

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

@vifer vifer requested a review from alecsammon May 7, 2024 15:24
@vifer vifer merged commit c78593e into main May 7, 2024
5 checks passed
@vifer vifer deleted the docs/fix-overview-section branch May 7, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants