Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feate: Replace empty interfaces #31

Closed
wants to merge 1 commit into from
Closed

feate: Replace empty interfaces #31

wants to merge 1 commit into from

Conversation

davidgrayston-paddle
Copy link
Contributor

For consideration

Changed

  • Replace empty interfaces with any

github-actions[bot]
github-actions bot reviewed Oct 16, 2024
View reviewed changes
collection.go
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
unnecessary conversion (unconvert)

paddle-go-sdk/collection.go

Line 189 in fff8e2d

c.results = append(c.results, &Res[T]{value: any(e).(T)}) //nolint:forcetypeassert // we know the type is correct.

@davidgrayston-paddle davidgrayston-paddle mentioned this pull request Oct 16, 2024
Merged
@davidgrayston-paddle davidgrayston-paddle deleted the feat/replace-empty-interfaces branch October 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
do not merge norelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidgrayston-paddle