Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Webhook verifier unbounded IO read #56

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

mikeymike
Copy link
Contributor

@mikeymike mikeymike commented Dec 18, 2024

This patch addresses a theoretical issue related to the webhook verifier's handling of large requests. While this is not an actual vulnerability, excessive resource consumption could occur if an attacker gained access to signing secrets and sent oversized payloads.

@mikeymike mikeymike self-assigned this Dec 18, 2024
@mikeymike mikeymike requested a review from a team December 18, 2024 23:11
@gedasskikas gedasskikas changed the title fix: Webhook verifier ubounded IO read fix: Webhook verifier unbounded IO read Dec 19, 2024
@mikeymike mikeymike marked this pull request as ready for review December 19, 2024 10:56
@mikeymike mikeymike requested a review from a team as a code owner December 19, 2024 10:56
@mikeymike mikeymike merged commit 1a56803 into main Dec 19, 2024
5 checks passed
@mikeymike mikeymike deleted the fix/unbounded-request-body-ingestion branch December 19, 2024 11:01
mikeymike added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants