fix: Discount expires_at is now DateTime

PaddleHQ · Nov 7, 2024 · 4822a70 · 4822a70
1 parent 2def986
commit 4822a70
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 Check our main [developer changelog](https://developer.paddle.com/?utm_source=dx&utm_medium=paddle-python-sdk) for information about changes to the Paddle Billing platform, the Paddle API, and other developer tools.
 
+## 1.0.0 - 2024-11-07
+
+### Changed
+
+- `paddle_billing.Resources.Discounts.Operations.CreateDiscount` `expires_at` is now `paddle_billing.Entities.DateTime`
+- `paddle_billing.Resources.Discounts.Operations.UpdateDiscount` `expires_at` is now `paddle_billing.Entities.DateTime`
+
 ## 0.3.2 - 2024-11-07
 
 ### Fixed

diff --git a/paddle_billing/Client.py b/paddle_billing/Client.py
@@ -206,7 +206,7 @@ def build_request_session(self) -> Session:
                 "Authorization": f"Bearer {self.__api_key}",
                 "Content-Type": "application/json",
                 "Paddle-Version": str(self.use_api_version),
-                "User-Agent": "PaddleSDK/python 0.3.2",
+                "User-Agent": "PaddleSDK/python 1.0.0",
             }
         )
 

diff --git a/paddle_billing/Resources/Discounts/Operations/CreateDiscount.py b/paddle_billing/Resources/Discounts/Operations/CreateDiscount.py
@@ -1,6 +1,7 @@
 from dataclasses import asdict, dataclass
 
 from paddle_billing.Undefined import Undefined
+from paddle_billing.Entities.DateTime import DateTime
 from paddle_billing.Entities.Discounts import DiscountType
 from paddle_billing.Entities.Shared import CurrencyCode, CustomData
 
@@ -17,7 +18,7 @@ class CreateDiscount:
     maximum_recurring_intervals: int | None | Undefined = Undefined()
     usage_limit: int | None | Undefined = Undefined()
     restrict_to: list[str] | None | Undefined = Undefined()
-    expires_at: str | None | Undefined = Undefined()
+    expires_at: DateTime | None | Undefined = Undefined()
     custom_data: CustomData | None | Undefined = Undefined()
 
     def get_parameters(self) -> dict:

diff --git a/paddle_billing/Resources/Discounts/Operations/UpdateDiscount.py b/paddle_billing/Resources/Discounts/Operations/UpdateDiscount.py
@@ -1,6 +1,7 @@
 from dataclasses import asdict, dataclass
 
 from paddle_billing.Undefined import Undefined
+from paddle_billing.Entities.DateTime import DateTime
 from paddle_billing.Entities.Discounts import DiscountStatus, DiscountType
 from paddle_billing.Entities.Shared import CurrencyCode, CustomData
 
@@ -17,7 +18,7 @@ class UpdateDiscount:
     maximum_recurring_intervals: int | None | Undefined = Undefined()
     usage_limit: int | None | Undefined = Undefined()
     restrict_to: list[str] | None | Undefined = Undefined()
-    expires_at: str | None | Undefined = Undefined()
+    expires_at: DateTime | None | Undefined = Undefined()
     status: DiscountStatus | Undefined = Undefined()
     custom_data: CustomData | None | Undefined = Undefined()
 

diff --git a/setup.py b/setup.py
@@ -2,7 +2,7 @@
 
 
 setup(
-    version="0.3.2",
+    version="1.0.0",
     author="Paddle and contributors",
     author_email="[email protected]",
     description="Paddle's Python SDK for Paddle Billing",

diff --git a/tests/Functional/Resources/Discounts/_fixtures/request/create_full.json b/tests/Functional/Resources/Discounts/_fixtures/request/create_full.json
@@ -12,7 +12,7 @@
         "pro_01gsz4t5hdjse780zja8vvr7jg",
         "pro_01gsz4s0w61y0pp88528f1wvvb"
     ],
-    "expires_at": "2025-01-01 10:00:00",
+    "expires_at": "2025-01-01T10:00:00.000000Z",
     "custom_data": {
         "key": "value"
     }

diff --git a/tests/Functional/Resources/Discounts/_fixtures/request/update_full.json b/tests/Functional/Resources/Discounts/_fixtures/request/update_full.json
@@ -12,7 +12,7 @@
         "pro_01gsz4t5hdjse780zja8vvr7jg",
         "pro_01gsz4s0w61y0pp88528f1wvvb"
     ],
-    "expires_at": "2025-01-01 10:00:00",
+    "expires_at": "2025-01-01T10:00:00.000000Z",
     "status": "active",
     "custom_data": {
         "key": "value"

diff --git a/tests/Functional/Resources/Discounts/test_DiscountsClient.py b/tests/Functional/Resources/Discounts/test_DiscountsClient.py
@@ -3,6 +3,7 @@
 from urllib.parse import unquote
 
 from paddle_billing.Entities.Collections import DiscountCollection
+from paddle_billing.Entities.DateTime import DateTime
 from paddle_billing.Entities.Discount import Discount
 from paddle_billing.Entities.Discounts import DiscountStatus, DiscountType
 from paddle_billing.Entities.Shared import CurrencyCode, Status, CustomData
@@ -43,7 +44,7 @@ class TestDiscountsClient:
                     maximum_recurring_intervals=5,
                     usage_limit=1000,
                     restrict_to=["pro_01gsz4t5hdjse780zja8vvr7jg", "pro_01gsz4s0w61y0pp88528f1wvvb"],
-                    expires_at="2025-01-01 10:00:00",
+                    expires_at=DateTime("2025-01-01 10:00:00"),
                     custom_data=CustomData({"key": "value"}),
                 ),
                 ReadsFixtures.read_raw_json_fixture("request/create_full"),
@@ -144,7 +145,7 @@ def test_create_discount_response_has_custom_data(
                     code="ABCDE12345",
                     maximum_recurring_intervals=5,
                     usage_limit=1000,
-                    expires_at="2025-01-01 10:00:00",
+                    expires_at=DateTime("2025-01-01 10:00:00"),
                     status=DiscountStatus.Active,
                     restrict_to=[
                         "pro_01gsz4t5hdjse780zja8vvr7jg",