Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

add atan2 op #1058

Merged
merged 9 commits into from
Nov 23, 2022
Merged

add atan2 op #1058

merged 9 commits into from
Nov 23, 2022

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Nov 18, 2022 •
edited
Loading

#1115

  1. add atan2 op
  2. add undefined triangle function in cinn/runtime/cuda/cinn_cuda_runtime_source.cuh
  3. fix typo

@zrr1999 zrr1999 marked this pull request as draft November 18, 2022 08:17
@zrr1999 zrr1999 marked this pull request as ready for review November 18, 2022 08:29
@zrr1999 zrr1999 marked this pull request as draft November 18, 2022 11:57
@zrr1999 zrr1999 changed the title add atanh2 asin2 asinh2 acosh2 acos2 ops add atanh2 op Nov 18, 2022
@zrr1999 zrr1999 changed the title add atanh2 op add atan2 op Nov 19, 2022
@zrr1999 zrr1999 marked this pull request as ready for review November 19, 2022 16:25
@zrr1999
Copy link
Member Author

zrr1999 commented Nov 19, 2022 •
edited
Loading

@thisjiang ci已经通过，麻烦review一下

thisjiang
thisjiang reviewed Nov 21, 2022
View reviewed changes
cinn/frontend/net_builder.cc Outdated Show resolved Hide resolved
cinn/hlir/pe/broadcast.cc Outdated Show resolved Hide resolved
cinn/hlir/pe/broadcast.cc Outdated Show resolved Hide resolved
cinn/hlir/pe/broadcast.cc Outdated Show resolved Hide resolved
thisjiang
thisjiang reviewed Nov 22, 2022
View reviewed changes
cinn/hlir/op/broadcast.cc Outdated Show resolved Hide resolved
cinn/hlir/pe/broadcast.cc Outdated Show resolved Hide resolved
@zrr1999 zrr1999 requested review from thisjiang November 22, 2022 07:51
@zrr1999 zrr1999 requested review from thisjiang November 22, 2022 07:51
thisjiang
thisjiang approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@thisjiang thisjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisjiang thisjiang merged commit 75f311d into PaddlePaddle:develop Nov 23, 2022
@qlogcn qlogcn mentioned this pull request Dec 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thisjiang thisjiang Awaiting requested review from thisjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zrr1999 @thisjiang